@abh3 requested changes on this pull request.

It would appear that this pull request is based on a previous version. Specifically, line 572 was added to XrdMacaroonsHandler.cc and should have appeared as

macaroon_resp.push_back((char)0);

and does not appear in this pull request. Could you rebase your branch to the latest master and resubmit the pull request?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1630#pullrequestreview-895878359", "url": "https://github.com/xrootd/xrootd/pull/1630#pullrequestreview-895878359", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1