Print

Print


@matthewfeickert commented on this pull request.



> @@ -653,7 +653,15 @@ popd
 pushd xrootd
 pushd  build
 make install DESTDIR=$RPM_BUILD_ROOT
-cat PYTHON_INSTALLED | sed -e "s|$RPM_BUILD_ROOT||g" > PYTHON_INSTALLED_FILES
+
+%if %{python3only}

I'm not very familiar with the RPM packaging spec, so I did this as there [doesn't seem to be a conditional](https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html-single/rpm_packaging_guide/index#rpm-conditionals-syntax_rpm-conditionals) for something like `%ifnot %{python3only}`. If there is negation, then this can be simplified.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1610#pullrequestreview-873903752
You are receiving this because you are subscribed to this thread.

Message ID: <[log in to unmask]>

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1