Print

Print

@matthewfeickert commented on this pull request.

In packaging/rhel/xrootd.spec.in:

> @@ -653,7 +653,15 @@ popd
 pushd xrootd
 pushd  build
 make install DESTDIR=$RPM_BUILD_ROOT
-cat PYTHON_INSTALLED | sed -e "s|$RPM_BUILD_ROOT||g" > PYTHON_INSTALLED_FILES
+
+%if %{python3only}

I'm not very familiar with the RPM packaging spec, so I did this as there doesn't seem to be a conditional for something like %ifnot %{python3only}. If there is negation, then this can be simplified.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1610/review/873903752@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1610#pullrequestreview-873903752", "url": "https://github.com/xrootd/xrootd/pull/1610#pullrequestreview-873903752", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1