Print

Print


@wyang007 commented on this pull request.


In src/XrdPosix/XrdPosixXrootd.cc:

> @@ -1040,6 +1047,7 @@ int XrdPosixXrootd::Readdir64_r(DIR *dirp, struct dirent64  *entry,
 /*                                R e n a m e                                 */
 /******************************************************************************/
 
+int ec_rename(const char*, const char*, XrdPosixAdmin*);

I moved they as private methods of the class, as you wish. I just didn't think the anyone who read the .hh needs to even know the existence of these methods, as they serve no other purposed than making the code more readable.

done


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1599/review/873905834@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1599#discussion_r800016717", "url": "https://github.com/xrootd/xrootd/pull/1599#discussion_r800016717", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1