Print

Print


@matthewfeickert commented on this pull request.


In bindings/python/CMakeLists.txt:

> @@ -81,8 +81,7 @@ if ( NOT ${VALID_PIP_EXIT_CODE} EQUAL 0 )
       COMMAND ${PYTHON_EXECUTABLE} ${SETUP_PY} install \
                 ${PIP_INSTALL_VERBOSE_FLAG} \
                 --prefix \$ENV{DESTDIR}/${CMAKE_INSTALL_PREFIX} \
-                ${DEB_INSTALL_ARGS} \
-                --record PYTHON_INSTALLED
+                ${DEB_INSTALL_ARGS}

a6a1fda removed all use of PYTHON_INSTALLED so no need to use --record here anymore.


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1610/review/874899457@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1610#pullrequestreview-874899457", "url": "https://github.com/xrootd/xrootd/pull/1610#pullrequestreview-874899457", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1