LISTSERV 16.5 - XROOTD-DEV Archives

@abh3 requested changes on this pull request.

> @@ -46,6 +46,7 @@
 
 #include "XrdPosix/XrdPosixOsDep.hh"
 #include "XrdSys/XrdSysPthread.hh"
+#include "XrdPosix/XrdPosixAdmin.hh"

I'd prefer you forward declare this object. No need to mess up the where PosixXrootd.hh is included as only needed in the cc file.

In src/XrdPosix/XrdPosixXrootd.hh:

> @@ -46,6 +46,7 @@
 
 #include "XrdPosix/XrdPosixOsDep.hh"
 #include "XrdSys/XrdSysPthread.hh"
+#include "XrdPosix/XrdPosixAdmin.hh"
 
 struct XrdOucIOVec;

And here is a good place to forward declare XrdPosixAdmin

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1599#pullrequestreview-875532414", "url": "https://github.com/xrootd/xrootd/pull/1599#pullrequestreview-875532414", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1