@dellaric commented on this pull request.

>  
-   return nullptr;

The return nullptr line wants to stay:

/tmp/xrootd-5.4.1-rc1/src/XrdVoms/XrdVomsMapfile.cc: In static member function static void* XrdVomsMapfile::MaintenanceThread(void*)':
/tmp/xrootd-5.4.1-rc1/src/XrdVoms/XrdVomsMapfile.cc:423:1: error: no return statement in function returning non-void [-Werror=return-type]
}
^
cc1plus: all warnings being treated as errors

Regards,
Giuseppe.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1572#pullrequestreview-880038540", "url": "https://github.com/xrootd/xrootd/pull/1572#pullrequestreview-880038540", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1