@abh3 requested changes on this pull request.
Giuseppe found an apparent missing return statement.
> + // allowing us to detect those changes as well.
+ //
+ if ((myself->m_mapfile_ctime.tv_sec == statbuf.st_ctim.tv_sec) &&
+ (myself->m_mapfile_ctime.tv_nsec == statbuf.st_ctim.tv_nsec))
+ {
+ myself->m_edest->Log(LogMask::Debug, "Maintenance", "Not reloading VOMS mapfile; "
+ "no changes detected.");
+ continue;
+ }
+ memcpy(&myself->m_mapfile_ctime, &statbuf.st_ctim, sizeof(decltype(statbuf.st_ctim)));
+
+ myself->m_edest->Log(LogMask::Debug, "Maintenance", "Reloading VOMS mapfile now");
+ if ( !(myself->m_is_valid = myself->ParseMapfile(myself->m_mapfile)) ) {
+ myself->m_edest->Log(LogMask::Error, "Maintenance", "Failed to reload VOMS mapfile");
+ }
+ }
Apparently we neeed a return statement here. Suggestion is
return nullptr;
See comment from Giuseppe.
--
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1572#pullrequestreview-880824428
You are receiving this because you are subscribed to this thread.
Message ID: <[log in to unmask]>
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
