This patch enable user/packager to override operating-system-related default values such as CMAKE__INSTALL_BINDIR.

With the use of GNUInstallDirs module, package maintainers of Linux, kFreeBSD and GNU can override those values through -DCMAKE_INSTALL_BINDIR=my/custom/path. However, for OSes such as MacOSX, FreeBSD and Solaries, those "default" values are hard-coded and unchangeable without modifying the source code. This has already cause problem to the Nix package.

In GNUInstallDirs, those values are set after the prior definition are explicitly checked, E.g.

if(NOT DEFINED CMAKE_INSTALL_BINDIR)
  set(CMAKE_INSTALL_BINDIR "bin" CACHE PATH "user executables (bin)")
endif()

which is quite lengthy. Fortunately, we already have define_default macro defined in XRootDUtils that does exactly the same thing.

This patch makes use of define_default to make those default values overridable.

You can view, comment on, or merge this pull request online at:

https://github.com/xrootd/xrootd/pull/1619

Commit Summary

2178cf9 [CMake] XRootDOSDefs: Use define_default on default values

File Changes

(1 file)

M cmake/XRootDOSDefs.cmake (36)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1619", "url": "https://github.com/xrootd/xrootd/pull/1619", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1