Print

Print


@simpsonst : thanks a lot for your PR! My understanding is that those 3 commits are yours:

[Set vector's logical size to avoid bounds-checking failure.](https://github.com/xrootd/xrootd/pull/1630/commits/989e088ca3375d95b035abd0130e78689d4d28c9)
[Vector must be resized to prevent bounds-checking assertion failure.](https://github.com/xrootd/xrootd/pull/1630/commits/666d8acaf162a49a1851cab220a5c5b4740dc776)
[Set vector's logical size to avoid bounds-checking failure.](https://github.com/xrootd/xrootd/pull/1630/commits/989e088ca3375d95b035abd0130e78689d4d28c9)

Now, we need to rework the PR so it contains only those 3 commits, unfortunately in the current form we cannot merge it because it pollutes the history, which in turn makes it very difficult to cut bugfix releases. What I would suggest is that you either:
- remove the redundant commits from your branch and then rebase on master, or
- create a new branch from master, `cherry-pick` the 3 commits and then replace the PR branch

Let me know if you need any help!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1630#issuecomment-1055225354
You are receiving this because you are subscribed to this thread.

Message ID: <[log in to unmask]>

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1