Print

Print


  Branch: refs/heads/master
  Home:   https://github.com/xrootd/xrootd
  Commit: 0bca0668468b0979fd0377effab918e2a98b49f8
      https://github.com/xrootd/xrootd/commit/0bca0668468b0979fd0377effab918e2a98b49f8
  Author: Matthew Feickert <[log in to unmask]>
  Date:   2022-03-15 (Tue, 15 Mar 2022)

  Changed paths:
    M bindings/python/CMakeLists.txt
    M cmake/XRootDDefaults.cmake

  Log Message:
  -----------
  [cmake] Add PIP_OPTIONS option for Python bindings install control

Add CMake option PIP_OPTIONS to allow the user to pass in pip options
at build configuration time to customize the Python bindings install.
As '--verbose' is a pip option, this makes the PIP_VERBOSE CMake option
added in PR 1586 redundant, and so it is removed. Additionally, as '--prefix'
is also a pip option, append the selected default value of
'$ENV{DESTDIR}/{CMAKE_INSTALL_PREFIX}' as a '--prefix' pip option if there is
no '--prefix' given by the user. If there is a given '--prefix' from the user in
PIP_OPTIONS already, warn the user that this might not be a good idea unless
they know what they're doing.

Adrian provided the idea of providing the user a PIP_OPTIONS CMake variable at build
configure time.
Henry provided help on getting PIP_OPTIONS to be recognized as a string by defult.

Co-authored-by: Adrian Sevcenco <[log in to unmask]>
Co-authored-by: Henry Schreiner <[log in to unmask]>


  Commit: e0213b14c4eb9145e6b444f26d7b1356a6400560
      https://github.com/xrootd/xrootd/commit/e0213b14c4eb9145e6b444f26d7b1356a6400560
  Author: Matthew Feickert <[log in to unmask]>
  Date:   2022-03-15 (Tue, 15 Mar 2022)

  Changed paths:
    M packaging/debian/rules

  Log Message:
  -----------
  [Debian] Remove PYTHON_LAYOUT option as no longer used in Python 3

Remove PYTHON_LAYOUT from override_dh_auto_configure as not used in
Python 3 builds.


  Commit: 16343d2162ee08c0ab589a1b1004f533fe48972e
      https://github.com/xrootd/xrootd/commit/16343d2162ee08c0ab589a1b1004f533fe48972e
  Author: Matthew Feickert <[log in to unmask]>
  Date:   2022-03-15 (Tue, 15 Mar 2022)

  Changed paths:
    M .github/workflows/build.yml

  Log Message:
  -----------
  [CI] Use PIP_OPTIONS in build tests

Use PIP_OPTIONS in the build tests in CI to pass the '--verbose' flag.
As an example of how multiple pip options can be passed as a single string
to PIP_OPTIONS, show in one test that '--force-reinstall' and '--prefix'
options can be used.


  Commit: 4e9b15df462cc985bc1128ad4aa161abdd55376e
      https://github.com/xrootd/xrootd/commit/4e9b15df462cc985bc1128ad4aa161abdd55376e
  Author: simonmichal <[log in to unmask]>
  Date:   2022-03-17 (Thu, 17 Mar 2022)

  Changed paths:
    M .github/workflows/build.yml
    M bindings/python/CMakeLists.txt
    M cmake/XRootDDefaults.cmake
    M packaging/debian/rules

  Log Message:
  -----------
  Merge pull request #1648 from matthewfeickert/feat/add-pip-options-cmake-option

feat: Add PIP_OPTIONS CMake option for greater control of Python bindings install


Compare: https://github.com/xrootd/xrootd/compare/5babd8c81c6e...4e9b15df462c

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1