... but using a tag like v5.4.2-alice1 lead to have in the installation output the following:

2022-03-18@20:37:29:DEBUG:xjalienfs:XRootD:xjalienfs: Processing ./bindings/python
2022-03-18@20:37:29:DEBUG:xjalienfs:XRootD:xjalienfs:   Preparing metadata (setup.py): started
2022-03-18@20:37:30:DEBUG:xjalienfs:XRootD:xjalienfs:   Preparing metadata (setup.py): finished with status 'done'
2022-03-18@20:37:30:DEBUG:xjalienfs:XRootD:xjalienfs: Building wheels for collected packages: xrootd
2022-03-18@20:37:30:DEBUG:xjalienfs:XRootD:xjalienfs:   Building wheel for xrootd (setup.py): started
2022-03-18@20:37:45:DEBUG:xjalienfs:XRootD:xjalienfs:   Building wheel for xrootd (setup.py): finished with status 'done'
2022-03-18@20:37:45:DEBUG:xjalienfs:XRootD:xjalienfs:   Created wheel for xrootd: filename=xrootd-5.4.2.alice1-cp39-cp39-macosx_11_0_x86_64.whl size=116509 sha256=e6b02ad7771e3fc7152bd986d6d6da05b767743a93751006f3e097b586169485
2022-03-18@20:37:45:DEBUG:xjalienfs:XRootD:xjalienfs:   Stored in directory: /Users/asevcenc/alisw/xjalienfs/tmp/pip-ephem-wheel-cache-ip6a62d3/wheels/23/b1/eb/d9212dc46f10e96cf8facd5e8766a597b638202d45ccba45be
2022-03-18@20:37:45:DEBUG:xjalienfs:XRootD:xjalienfs:   WARNING: Built wheel for xrootd is invalid: Metadata 1.2 mandates PEP 440 version, but '5.4.2.alice1' is not
2022-03-18@20:37:45:DEBUG:xjalienfs:XRootD:xjalienfs: Failed to build xrootd
2022-03-18@20:37:45:DEBUG:xjalienfs:XRootD:xjalienfs: Installing collected packages: xrootd
2022-03-18@20:37:45:DEBUG:xjalienfs:XRootD:xjalienfs:   Running setup.py install for xrootd: started
2022-03-18@20:37:46:DEBUG:xjalienfs:XRootD:xjalienfs:   Running setup.py install for xrootd: finished with status 'done'
2022-03-18@20:37:46:DEBUG:xjalienfs:XRootD:xjalienfs:   DEPRECATION: xrootd was installed using the legacy 'setup.py install' method, because a wheel could not be built for it. A possible replacement is to fix the wheel build issue reported above. Discussion can be found at https://github.com/pypa/pip/issues/8368
2022-03-18@20:37:46:DEBUG:xjalienfs:XRootD:xjalienfs: Successfully installed xrootd-5.4.2.alice1

is there anything to worry about the future? Thanks a lot!

My assumption is that the installed xrootd-5.4.2.alice1 still works fine, correct? If so, then I don't think there's anything to worry about as it is simply pip enforcing PEP 440. c.f. #1605 for more details, but an example of what I mean (also shown there) is

from pip._vendor.packaging.version import Version

Version("5.4.2")  # <Version('5.4.2')>
Version("5.4.3rc1")  # <Version('5.4.3rc1')>
Version("5.4.2.alice1")  # pip._vendor.packaging.version.InvalidVersion: Invalid version: '5.4.2.alice1'

and my assumption is that this is happening to you on a fork that you have where you've made this tag as (the existing publish.sh workflow calls genversion.sh

https://github.com/xrootd/xrootd/blob/62d11709ca6247cec3c40596be7b9948f885f9e3/packaging/wheel/publish.sh#L3-L6

which uses tags to set version info (I learned how the existing system XRootD uses works only by making PRs like #1585, so I don't think that any of this should be obvious).

This PR should be totally unrelated from any of the above though, as none of the files being removed here participate in the build or the install (so you should be able to get the same warning on master with your tag).


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1656/c1072802317@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1656#issuecomment-1072802317", "url": "https://github.com/xrootd/xrootd/pull/1656#issuecomment-1072802317", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1