@matthewfeickert requested changes on this pull request.
> @@ -78,7 +78,7 @@ if ( NOT ${VALID_PIP_EXIT_CODE} EQUAL 0 )
install(
CODE
"EXECUTE_PROCESS(
- COMMAND ${PYTHON_EXECUTABLE} ${SETUP_PY} install \
+ COMMAND /usr/bin/env CC=c++ CFLAGS=\"-std=c++17\" ${PYTHON_EXECUTABLE} ${SETUP_PY} install \
You definitely do not want to hardcode this anywhere. This should be set through CMake at build configure time with the `CMAKE_C_FLAGS` and `CMAKE_CXX_FLAGS`. c.f. https://cmake.org/cmake/help/latest/variable/CMAKE_LANG_FLAGS.html for more details.
--
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1651#pullrequestreview-914879687
You are receiving this because you are subscribed to this thread.
Message ID: <[log in to unmask]>
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
