@ktf commented on this pull request.


In bindings/python/CMakeLists.txt:

> @@ -78,7 +78,7 @@ if ( NOT ${VALID_PIP_EXIT_CODE} EQUAL 0 )
   install(
     CODE
     "EXECUTE_PROCESS(
-      COMMAND ${PYTHON_EXECUTABLE} ${SETUP_PY} install \
+    COMMAND /usr/bin/env CC=c++ CFLAGS=\"-std=c++17\" ${PYTHON_EXECUTABLE} ${SETUP_PY} install \

You misunderstood my point. The issue is the setup.py which decides to go for the CC / CFLAGS in order to compile a C++11 python module. Notice this affects also some ubuntu versions.


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1651/review/914976910@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1651#discussion_r830449931", "url": "https://github.com/xrootd/xrootd/pull/1651#discussion_r830449931", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1