LISTSERV 16.5 - XROOTD-DEV Archives

@matthewfeickert commented on this pull request.

> @@ -78,7 +78,7 @@ if ( NOT ${VALID_PIP_EXIT_CODE} EQUAL 0 )
   install(
     CODE
     "EXECUTE_PROCESS(
-      COMMAND ${PYTHON_EXECUTABLE} ${SETUP_PY} install \
+    COMMAND /usr/bin/env CC=c++ CFLAGS=\"-std=c++17\" ${PYTHON_EXECUTABLE} ${SETUP_PY} install \

@ktf I would suggest that you make a GitHub Issue to discuss this and to clearly describe what the Issue is, what you want to have happen, what in the codebase needs to get changed, and what you plan to implement.

Also, as @adriansev already pointed out, your PR is targeting the wrong branch. If you refactor this PR to provide a solution that has been agreed upon in the GitHub issue then you should have it target the master branch.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1651#discussion_r830710474", "url": "https://github.com/xrootd/xrootd/pull/1651#discussion_r830710474", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1