`command -v` is a POSIX safe way to find an executable program. While `which` is very common, it still requires installation on many Linux operating systems, and so `command -v` can offer a more portable alternative with a very low amount of additional cognitive overhead on the maintainers.
Additionally, use a subshell, `$()`, over backticks for command substitution as `$()` is recommended for multiple reasons including readability.
c.f.:
* https://stackoverflow.com/a/4708569/8931942
* [Why is $(...) preferred over `...` (backticks)?](http://mywiki.wooledge.org/BashFAQ/082)
* [POSIX spec for Command Substitution](https://pubs.opengroup.org/onlinepubs/9699919799/xrat/V4_xcu_chap02.html#tag_23_02_06_03)
You can view, comment on, or merge this pull request online at:
https://github.com/xrootd/xrootd/pull/1658
-- Commit Summary --
* [packaging] Use 'command -v' over 'which' for portability
* [CI] Remove install of 'which' from GHA based CI
* [CI] Remove install of 'which' from GitLab Pipelines CI
-- File Changes --
M .github/workflows/build.yml (7)
M .gitlab-ci.yml (28)
M genversion.sh (4)
M packaging/makesrpm.sh (2)
-- Patch Links --
https://github.com/xrootd/xrootd/pull/1658.patch
https://github.com/xrootd/xrootd/pull/1658.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1658
You are receiving this because you are subscribed to this thread.
Message ID: <[log in to unmask]>
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
