Branch: refs/heads/master
Home: https://github.com/xrootd/xrootd
Commit: 8d6b47bd90b0825f9a38d6f06c2b3310db983ff7
https://github.com/xrootd/xrootd/commit/8d6b47bd90b0825f9a38d6f06c2b3310db983ff7
Author: Matthew Feickert <[log in to unmask]>
Date: 2022-03-22 (Tue, 22 Mar 2022)
Changed paths:
M genversion.sh
M packaging/makesrpm.sh
Log Message:
-----------
[packaging] Use 'command -v' over 'which' for portability
'command -v' is a POSIX safe way to find an executable program.
While 'which' is very common, it still requires installation on many
Linux operating systems, and so 'command -v' can offer a more portable
alternative with a very low amount of additional cognitive overhead on
the maintainers.
Additionally, use a subshell, $(), over backticks for command substitution
as $() is recommended for multiple reasons including readability.
c.f.:
* https://stackoverflow.com/a/4708569/8931942
* Why is $(...) preferred over `...` (backticks)?
- http://mywiki.wooledge.org/BashFAQ/082
* POSIX spec for Command Substitution
- https://pubs.opengroup.org/onlinepubs/9699919799/xrat/V4_xcu_chap02.html#tag_23_02_06_03
Commit: 7d98c17a8244389d20e4b63113c17d418d846fac
https://github.com/xrootd/xrootd/commit/7d98c17a8244389d20e4b63113c17d418d846fac
Author: Matthew Feickert <[log in to unmask]>
Date: 2022-03-22 (Tue, 22 Mar 2022)
Changed paths:
M .github/workflows/build.yml
Log Message:
-----------
[CI] Remove install of 'which' from GHA based CI
Commit: 95122aded40574a14bac43417fb1c58ea7b33428
https://github.com/xrootd/xrootd/commit/95122aded40574a14bac43417fb1c58ea7b33428
Author: Matthew Feickert <[log in to unmask]>
Date: 2022-03-22 (Tue, 22 Mar 2022)
Changed paths:
M .gitlab-ci.yml
Log Message:
-----------
[CI] Remove install of 'which' from GitLab Pipelines CI
Commit: 2ed76c1d2f3fbfa8994c3a7cf0ab94e553cfce42
https://github.com/xrootd/xrootd/commit/2ed76c1d2f3fbfa8994c3a7cf0ab94e553cfce42
Author: simonmichal <[log in to unmask]>
Date: 2022-03-22 (Tue, 22 Mar 2022)
Changed paths:
M .github/workflows/build.yml
M .gitlab-ci.yml
M genversion.sh
M packaging/makesrpm.sh
Log Message:
-----------
Merge pull request #1658 from matthewfeickert/feat/use-command-over-which
chore: Use `command -v` over `which` for portability
Compare: https://github.com/xrootd/xrootd/compare/279b0d3212b7...2ed76c1d2f3f
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
