@simpsonst : thanks a lot for your PR! My understanding is that those 3 commits are yours:

Set vector's logical size to avoid bounds-checking failure.
Vector must be resized to prevent bounds-checking assertion failure.
Set vector's logical size to avoid bounds-checking failure.

Now, we need to rework the PR so it contains only those 3 commits, unfortunately in the current form we cannot merge it because it pollutes the history, which in turn makes it very difficult to cut bugfix releases. What I would suggest is that you either:

remove the redundant commits from your branch and then rebase on master, or
create a new branch from master, cherry-pick the 3 commits and then replace the PR branch

Let me know if you need any help!

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1630#issuecomment-1055225354", "url": "https://github.com/xrootd/xrootd/pull/1630#issuecomment-1055225354", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1