@matthewfeickert commented on this pull request.
> install(
CODE
"EXECUTE_PROCESS(
COMMAND ${PYTHON_EXECUTABLE} -m pip install \
- ${PIP_INSTALL_VERBOSE_FLAG} \
- --force-reinstall \
+ ${PIP_OPTIONS} \
--prefix \$ENV{DESTDIR}/${CMAKE_INSTALL_PREFIX} \
If we're taking `PIP_OPTIONS` to its logical extreme, we should also check to see if `--prefix` exists in `PIP_OPTIONS` and if so default to that instead of `\$ENV{DESTDIR}/${CMAKE_INSTALL_PREFIX}` but we should also throw a warning to let the user know they're doing something probably bad!
--
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1648#pullrequestreview-908209866
You are receiving this because you are subscribed to this thread.
Message ID: <[log in to unmask]>
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
