@matthewfeickert commented on this pull request.


In cmake/XRootDDefaults.cmake:

> @@ -18,7 +18,7 @@ option( ENABLE_XRDCL     "Enable XRootD client."
 option( ENABLE_TESTS     "Enable unit tests."                                             FALSE )
 option( ENABLE_HTTP      "Enable HTTP component."                                         TRUE )
 option( ENABLE_PYTHON    "Enable python bindings."                                        TRUE )
-option( PIP_VERBOSE      "Turn on --verbose flag for pip during Python bindings install." FALSE )
+option( PIP_OPTIONS      "pip options to use during the Python bindings install."         STRING )

@henryiii Sorry to bother you with a CMake question, but can you remind me how to properly escape an option like there where there will be spaces in the string? I assume that there is a standard way of doing things like this that you use in the Scikit-build world.


Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1648/review/908212349@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1648#pullrequestreview-908212349", "url": "https://github.com/xrootd/xrootd/pull/1648#pullrequestreview-908212349", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1