 |
 |
@matthewfeickert commented on this pull request. > @@ -18,7 +18,7 @@ option( ENABLE_XRDCL "Enable XRootD client." option( ENABLE_TESTS "Enable unit tests." FALSE ) option( ENABLE_HTTP "Enable HTTP component." TRUE ) option( ENABLE_PYTHON "Enable python bindings." TRUE ) -option( PIP_VERBOSE "Turn on --verbose flag for pip during Python bindings install." FALSE ) +option( PIP_OPTIONS "pip options to use during the Python bindings install." "" ) > so, i checkout out the PR and gave it a spin: > > 1. without any additional options the python bindings are not installed and i get: > > ``` > Processing ./bindings/python > Preparing metadata (setup.py): started > Preparing metadata (setup.py): finished with status 'done' > ERROR: Could not find a version that satisfies the requirement OFF (from versions: none) > ERROR: No matching distribution found for OFF > ``` > > i suspect that some defaults (empty variable) are not well enough processed Ah okay @adriansev this is useful info. This means that indeed, `PIP_OPTIONS` is getting set to a BOOL of OFF and not being set as an empty string by default. I'll need to figure out how to guard against this. @henryiii if this is obvious to you, can you suggest a fix to me? -- Reply to this email directly or view it on GitHub: https://github.com/xrootd/xrootd/pull/1648#pullrequestreview-908937224 You are receiving this because you are subscribed to this thread. Message ID: <[log in to unmask]> ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1