Print

Print

Sorry, I missed something in 5ea2004. The vector::shrink_to_fit call at XrdTpcStream.hh line 133 relies upon the vector size (which used to be always 0) being less than its capacity. (It seems it's only invoked when 'low buffer occupancy' is detected.) Now the (size, capacity) will only ever be either (0, 0) or (m_capacity, >=m_capacity), instead of (0, 0) or (0, m_capacity), so shrink_to_fit won't be able to fully de-allocate. I don't think it's a functional failure, but it could mean the allocation is retained for longer than expected.
By clearing the vector just after its contents are transmitted (and when m_size and m_offset are reset, marking the buffer as empty and available), shrink_to_fit should become effective again.

You can view, comment on, or merge this pull request online at:

  https://github.com/xrootd/xrootd/pull/1639

Commit Summary

File Changes

(1 file)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1639@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1639", "url": "https://github.com/xrootd/xrootd/pull/1639", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1