Print

Print

@matthewfeickert commented on this pull request.

In bindings/python/CMakeLists.txt:

> @@ -32,10 +32,17 @@ endif()
 
 configure_file(${SETUP_PY_IN} ${SETUP_PY})
 
-if( PIP_VERBOSE )
-  set(PIP_INSTALL_VERBOSE_FLAG "--verbose")
+SET(PIP_OPTIONS "" CACHE STRING "pip options used during the Python bindings install.")
⬇️ Suggested change 
-SET(PIP_OPTIONS "" CACHE STRING "pip options used during the Python bindings install.")
+SET(PIP_OPTIONS "" CACHE STRING "pip options used during the Python bindings install.")

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1648/review/908947840@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1648#pullrequestreview-908947840", "url": "https://github.com/xrootd/xrootd/pull/1648#pullrequestreview-908947840", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1