Print

Print


> ## Question after all of this is fixed
> Why are wheels not working with `build`?

Because I made a mistake in PR #1585 and 

https://github.com/xrootd/xrootd/blob/81e57b5d4bf4de3e9a126484afc1923b9b08d5db/packaging/wheel/install.sh#L43-L44

will _always_ have `shutil_which_available` equal `0` as the syntax is wrong: It should be

```python
from shutil import which
```

:(

I have fixes on my fork that implement this as well as other things that should make things fully `distutils` deprecation safe. Though I have a question for @simonmichal and @adriansev that might impact how fast I am able to get a PR that can support everything: What is the minimum version of `pip` that you **need** to be able to build the Python wheel on?

CentOS7 ships very old `pip3` with `python3-devel` ([`pip` `v9.0.3`](https://pypi.org/project/pip/9.0.3/)). Are you willing to allow for things that require [`pip` `v20.0.1`](https://pypi.org/project/pip/20.0.1/) (released in 2020) if if **only affected building wheels from the sdist** with `packaging/wheel/install.sh` and not the CMake builds from source?

If you are okay with that then I can simplify all of this

https://github.com/xrootd/xrootd/blob/81e57b5d4bf4de3e9a126484afc1923b9b08d5db/packaging/wheel/install.sh#L61-L84

to 4 lines using `wheel` and `pip` (and that would only be to support CPython versions older than 3.3 — for more modern things `pip` can do it all itself.). Is that okay?



-- 
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/issues/1668#issuecomment-1101212638
You are receiving this because you are subscribed to this thread.

Message ID: <[log in to unmask]>

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1