Print

Print


@matthewfeickert commented on this pull request.


In packaging/wheel/install.sh:

> +# (shutil.which was added in Python 3.3, so any version of Python 3 now will have it)
+# TODO: Drop support for Python 3.3 and simplify to pip approach

In a follow up PR (to keep scope simple) if people are okay with dropping support for Python 3.1 and Python 3.2 (EOL was October 11, 2014) then this can all get simplified down to just using pip. As the wheels are assuming you're using Python 3 anyway this should not be a problem for anyone.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1672/review/944601950@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1672#pullrequestreview-944601950", "url": "https://github.com/xrootd/xrootd/pull/1672#pullrequestreview-944601950", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1