@abh3 requested changes on this pull request. Thanks, only one minor comment needs to be changed. I think it was forgotten as it references open+excl in rename. > @@ -2252,10 +2284,29 @@ int XrdOfs::rename(const char *old_name, // In evsObject->Notify(XrdOfsEvs::Mv, evInfo); } +// If we cannot overwrite, we must open-exclusive first. This will test whether Could you correct the comment? We no longer do an excl open here. -- Reply to this email directly or view it on GitHub: https://github.com/xrootd/xrootd/pull/1697#pullrequestreview-967042151 You are receiving this because you are subscribed to this thread. Message ID: <[log in to unmask]> ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1