@Nikipedia : thanks for the PR.

AFAIU the intention is that if the optional argument bufferSize is not provided the checks are omitted, which provides backwards compatibility (that's good :-).

I added 2 minor comments about moving throw to next line in if statement, could you please address them?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1742#issuecomment-1193868617", "url": "https://github.com/xrootd/xrootd/pull/1742#issuecomment-1193868617", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1