@simonmichal commented on this pull request.
> {
+ if(bufferSize > 0 && bufferSize < (uint64_t)lfhBaseSize) throw bad_data();
Could you please move the throw to a new line, this makes debugging with gdb easier.
> @@ -84,6 +85,8 @@ namespace XrdZip
from_buffer( uncompressedSize, buffer );
from_buffer( filenameLength, buffer );
from_buffer( extraLength, buffer );
+
+ if(bufferSize > 0 && (uint64_t)(lfhBaseSize + filenameLength + extraLength) > bufferSize) throw bad_data();
Could you please move the throw to a new line, this makes debugging with gdb easier.
--
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1742#pullrequestreview-1049210606
You are receiving this because you are subscribed to this thread.
Message ID: <[log in to unmask]>
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
