Print

Print

@simonmichal commented on this pull request.

In src/XrdZip/XrdZipLFH.hh:

>      {
+    	if(bufferSize > 0 && bufferSize < (uint64_t)lfhBaseSize) throw bad_data();

Could you please move the throw to a new line, this makes debugging with gdb easier.

In src/XrdZip/XrdZipLFH.hh:

> @@ -84,6 +85,8 @@ namespace XrdZip
       from_buffer( uncompressedSize, buffer );
       from_buffer( filenameLength, buffer );
       from_buffer( extraLength, buffer );
+
+      if(bufferSize > 0 && (uint64_t)(lfhBaseSize + filenameLength + extraLength) > bufferSize) throw bad_data();

Could you please move the throw to a new line, this makes debugging with gdb easier.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1742/review/1049210606@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1742#pullrequestreview-1049210606", "url": "https://github.com/xrootd/xrootd/pull/1742#pullrequestreview-1049210606", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1