@Nikipedia commented on this pull request.


In src/XrdCl/XrdClZipArchive.cc:

> @@ -321,10 +321,17 @@ namespace XrdCl
                                                             "End-of-central-directory signature not found." );
                                         Pipeline::Stop( error );
                                       }
+                                      try{

I forgot to pass the maxSize argument, and inserted it now as the length of the chunk we read minus the difference between the chunk start and eocd start, since this should give exactly the remaining mapped memory length. uint32_t is sufficient because the maximum reading length is just more than 65000.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1744/review/1049444731@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1744#discussion_r928868106", "url": "https://github.com/xrootd/xrootd/pull/1744#discussion_r928868106", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1