@abh3 commented on this pull request.
> @@ -238,7 +238,7 @@ static const uint64_t artON = 0x0000002000000000; //!< Auto retry Handshake
XrdTlsContext(const char *cert=0, const char *key=0,
const char *cadir=0, const char *cafile=0,
- uint64_t opts=0, std::string *eMsg=0);
+ uint64_t opts=0, std::string *eMsg=0,const bool startCRLRefreshThread = false);
I think it would be better here to have the startCRLRefreshThread to be included as an option in "opts". I also suggest saying with the namining convention for the option and making it "scRefr" with the value 0x20000000. I know hat does have a trickle effect of additional changes. So, since the default is not to start the thread not specifying scRefr does not start the thread..
--
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1791#pullrequestreview-1125194980
You are receiving this because you are subscribed to this thread.
Message ID: <[log in to unmask]>
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
