Print

Print

@abh3 commented on this pull request.

In src/XrdTls/XrdTlsContext.hh:

> @@ -238,7 +238,7 @@ static const uint64_t artON = 0x0000002000000000; //!< Auto retry Handshake
 
        XrdTlsContext(const char *cert=0,  const char *key=0,
                      const char *cadir=0, const char *cafile=0,
-                     uint64_t opts=0, std::string *eMsg=0);
+                     uint64_t opts=0, std::string *eMsg=0,const bool startCRLRefreshThread = false);

I think it would be better here to have the startCRLRefreshThread to be included as an option in "opts". I also suggest saying with the namining convention for the option and making it "scRefr" with the value 0x20000000. I know hat does have a trickle effect of additional changes. So, since the default is not to start the thread not specifying scRefr does not start the thread..

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1791/review/1125194980@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1791#pullrequestreview-1125194980", "url": "https://github.com/xrootd/xrootd/pull/1791#pullrequestreview-1125194980", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1