Print

Print

@barracuda156 I think that you would need to move your definition to XrdSys/XrdSysPlatform.hh
where __bswap_64 is aliased to htonll (and seems anyway to be the location for platform oriented fixes). Also, seems that direct usage of bswap in XrdOssCsiTagstoreFile is not really correct as in the interest of platforms support, the aliases from XrdSysPlatform.hh should be used.
@simonmichal can give an authoritative answer on this ..

The module in question is built only when GCC is used, Clang builds skip it, and since 10.7 Clang is the default compiler in Xcode and Macports – that is why no one noticed the error. So while the header in question is missing on MacOS generally, it is invoked only in one file, which I patched.

But if you advise moving the definitions to XrdSysPlatform.hh, let’s do it.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1766/c1236285421@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1766#issuecomment-1236285421", "url": "https://github.com/xrootd/xrootd/pull/1766#issuecomment-1236285421", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1