@amadio commented on this pull request.
In bindings/python/src/PyXRootDFileSystem.cc:
> uint8_t priority = 0; uint16_t timeout = 0; PyObject *pyfiles = NULL, *callback = NULL; PyObject *pyresponse = NULL, *pystatus = NULL; XrdCl::XRootDStatus status; - if ( !PyArg_ParseTupleAndKeywords( args, kwds, "OK|bHO:prepare", - (char**) kwlist, &pyfiles, &flags, &priority, &timeout, &callback ) ) + if ( !PyArg_ParseTupleAndKeywords( args, kwds, "OH|bHO:prepare",
Thanks for the detailed explanation! The change itself looks fine, I was just not sure why you decided to use the 16-bit integer explicitly. Maybe we could consider using enum Flags : uint16_t
where this enum
is created to ensure the type used is uint16_t
.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1