Print

Print


The problem is that with a single slash as in `\$ENV{DESTDIR}`, the variable gets expanded too early (i.e., when passing `${PIP_OPTIONS}` in the call to `install(CODE...)`), so when `make DESTDIR=$INSTALL_DIR install` is run, the variable is not part of the recipe, as `$ENV{DESTDIR}` has been passed to `install(CODE..)` and has been expanded into an empty value. By adding one more level of quoting, the expansion of `DESTDIR` happens at the right place and the staged installation works correctly.

Closes: #1768
You can view, comment on, or merge this pull request online at:

  https://github.com/xrootd/xrootd/pull/1822

-- Commit Summary --

  * [Python] Fix staged installation of Python bindings

-- File Changes --

    M bindings/python/CMakeLists.txt (2)

-- Patch Links --

https://github.com/xrootd/xrootd/pull/1822.patch
https://github.com/xrootd/xrootd/pull/1822.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1822
You are receiving this because you are subscribed to this thread.

Message ID: <[log in to unmask]>

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1