The problem is that with a single slash as in \$ENV{DESTDIR}, the variable gets expanded too early (i.e., when passing ${PIP_OPTIONS} in the call to install(CODE...)), so when make DESTDIR=$INSTALL_DIR install is run, the variable is not part of the recipe, as $ENV{DESTDIR} has been passed to install(CODE..) and has been expanded into an empty value. By adding one more level of quoting, the expansion of DESTDIR happens at the right place and the staged installation works correctly.

Closes: #1768

You can view, comment on, or merge this pull request online at:

https://github.com/xrootd/xrootd/pull/1822

Commit Summary

22ec5bd [Python] Fix staged installation of Python bindings

File Changes

(1 file)

M bindings/python/CMakeLists.txt (2)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1822", "url": "https://github.com/xrootd/xrootd/pull/1822", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1