@amadio commented on this pull request.

> -
-  endif()
-endif()
-
-
-#-------------------------------------------------------------------------------
-# Check for the TLS support in the OpenSSL version that is available
-# (assume available if use of static libs is detected and the openssl version
-# is at least 1.0.2)
-#-------------------------------------------------------------------------------
-
-if ( OPENSSL_FOUND )
-
-  if( OPENSSL_USE_STATIC AND OPENSSL_GOOD_VERSION )
-
-    add_definitions( -DHAVE_TLS -DHAVE_TLS12 -DHAVE_TLS11 -DHAVE_TLS1 -DHAVE_DH_PADDED -DHAVE_DH_PADDED_FUNC )

I think when CMake provides a find module, it's better to use the upstream one, unless the version of CMake we support doesn't provide it. Usually find modules should not change compile options of the projects using them, but just export which compile options may be needed as variables, etc. If we need to add_definitions(...) for things specific to XRootD, then we should do outside of the find module, like was already being done in cmake/XRootDFindLibs.cmake. At least for -DHAVE_TLS, the definition added by the find module was redundant.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1823#discussion_r1019255833", "url": "https://github.com/xrootd/xrootd/pull/1823#discussion_r1019255833", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1