Turned out that removing the #ifdef altogether was a bit too optimistic, so I replaced it with a versioned #ifdef instead to keep it working with both shared and static libraries of OpenSSL.

@simonmichal We could remove the #ifdef and keep using only the older SSLv23_method name, as that's a macro that defines it as TLS_method anyway in newer OpenSSL (and why we didn't see any problems when not adding -DHAVE_TLS before. Let me know if you prefer this, I did the #ifdef to ensure the current version is future-proof. We can drop the #ifdef when we move to require a newer version of OpenSSL (i.e. when CentOS 7 support is dropped).

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1823#issuecomment-1311476152", "url": "https://github.com/xrootd/xrootd/pull/1823#issuecomment-1311476152", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1