 |
 |
hi @simonmichal: Thanks for reviewing this. The original patch didn't intend to replace the key with the whole URL, but to avoid a double use of GetChannelId(), i.e. effectively the value URL(url.GetChannelId()).GetChannelId(), so I don't believe there should have been any problem introduced by switching to overly specific keys. But for sure another approach could be preferred. I tried the change you suggested which is fixing the parsing, of course that seems fine and I it solves the problem as I understand it. I've updated this PR so that it adds that change; so feel free to either eventually merge this pr, or close this and add your change directly. -- Reply to this email directly or view it on GitHub: https://github.com/xrootd/xrootd/pull/1824#issuecomment-1326210531 You are receiving this because you are subscribed to this thread. Message ID: <[log in to unmask]> ######################################################################## Use REPLY-ALL to reply to list To unsubscribe from the XROOTD-DEV list, click the following link: https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1