Print

Print

@abh3 commented on this pull request.

A question for you along with a suggested improvement.

In src/XrdSciTokens/XrdSciTokensAccess.cc:

> @@ -1083,6 +1083,16 @@ class XrdAccSciTokens : public XrdAccAuthorize, public XrdSciTokensHelper
                      section.c_str());
                 continue;
             }
+	    // prevent two identical issuers break the config 
+	    for (size_t i = 0; i < issuer.length(); i++)

Why didn't you use index() and instead implemented a manual version of it?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1859/review/1214629628@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1859#pullrequestreview-1214629628", "url": "https://github.com/xrootd/xrootd/pull/1859#pullrequestreview-1214629628", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1