Print

Print

@abh3 approved this pull request.

OK, I now understand why my tests succeeded and yours failed. It was a happenstance of the data we used. So, indeed, this is the correct fix as the verification stops when a bad checksum is encountered and the caller needs to redrive the check where it left off. So, yes, data needs to point to where the verification should resume.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1865/review/1218641549@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1865#pullrequestreview-1218641549", "url": "https://github.com/xrootd/xrootd/pull/1865#pullrequestreview-1218641549", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1