Print

Print


@amadio requested changes on this pull request.

I wonder if something that uses [`gethostname(2)`](https://man7.org/linux/man-pages/man2/gethostname.2.html) couldn't work in this case, rather than setting an environment variable. You could probably use `hostnamectl` from within your containers to adjust the hostname, no?

> @@ -94,7 +95,7 @@ static const char  *TraceID;
 XrdNetSecurity     *Police;
 XrdTcpMonInfo      *tmoInfo;
 const char         *myProg;
-const char         *myName;
+std::string         myName;

It does not seem to make sense to me to replace one `const char*` with `std::string`, while leaving all the rest as `const char*`.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1868#pullrequestreview-1219551066
You are receiving this because you are subscribed to this thread.

Message ID: <[log in to unmask]>

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1