Gentleman,
This is not the way I envisioned doing this and definitely not via an
envar that tends to get forgotten buruied and creates enormous problems.
We are up against holiday brtek. This is a new feature and won't be
included until a feature release anyway. So, please hold your horses and
stop rushing.
Andy
On Thu, 15 Dec 2022, Guilherme Amadio wrote:
> @amadio requested changes on this pull request.
>
> I wonder if something that uses [`gethostname(2)`](https://man7.org/linux/man-pages/man2/gethostname.2.html) couldn't work in this case, rather than setting an environment variable. You could probably use `hostnamectl` from within your containers to adjust the hostname, no?
>
>> @@ -94,7 +95,7 @@ static const char *TraceID;
> XrdNetSecurity *Police;
> XrdTcpMonInfo *tmoInfo;
> const char *myProg;
> -const char *myName;
> +std::string myName;
>
> It does not seem to make sense to me to replace one `const char*` with `std::string`, while leaving all the rest as `const char*`.
>
> --
> Reply to this email directly or view it on GitHub:
> https://github.com/xrootd/xrootd/pull/1868#pullrequestreview-1219551066
> You are receiving this because you are subscribed to this thread.
>
> Message ID: ***@***.***>
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Message ID: <xrootd/xrootd/pull/1868/c1354164272@github.com>
[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/xrootd/xrootd/pull/1868#issuecomment-1354164272",
"url": "https://github.com/xrootd/xrootd/pull/1868#issuecomment-1354164272",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
