Print

Print


@abh3 commented on this pull request.



> @@ -116,6 +116,14 @@ private:
   
   // Sanitize the resource from http[s]://[host]/ questionable prefix
   void sanitizeResourcePfx();
+
+   /**
+   * Select the checksum to be computed depending on the userDigest passed in parameter
+   * @param userDigest the digest request from the user (extracted from the Want-Digest header)
+   * @param selectedChecksum the checksum that will be performed
+   */
+  void selectChecksum(const std::string & userDigest, std::string & selectedChecksum);

I think this is OK as the method aded is non-virtual and the whole set of classes is in one library which gets replaced in any release update. So, it should not require recompilation of anything that was created by a user.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1890#discussion_r1091684876
You are receiving this because you are subscribed to this thread.

Message ID: <[log in to unmask]>

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1