@ccaffy commented on this pull request.


In src/XrdCl/XrdClUtils.hh:

> @@ -31,6 +31,7 @@
 #include "XrdCl/XrdClPostMaster.hh"
 #include "XrdCl/XrdClXRootDTransport.hh"
 #include "XrdNet/XrdNetUtils.hh"
+#include "XrdUtils/XrdUtils.hh"

Ah yes, so this I doubted when I did it... I did not know the existence of the XrdOucUtils.
I wanted the code to not be duplicated. I can remove my class and put it into the XrdOucUtils if you want.
For the XrdOucString, is there a wish that one day, this class is replaced by the std::string ? If yes, I believe we can keep the implementation of the splitString(...) method in XrdOucUtils 🤷‍♂️


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1890/review/1277120912@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1890#discussion_r1091880773", "url": "https://github.com/xrootd/xrootd/pull/1890#discussion_r1091880773", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1