Print

Print

However, if we're going to move CMake minimum requirements up, I'd rather push it to 3.16 instead of 3.12, because there are important fixes in the new FindPython modules and several other new features that we can make use of when updating the build system later.

@amadio Done. I've rebased and pushed these changes.

BTW, please add "Fixes: #1474" somewhere in your last commit message so the issue gets automatically closed when this is merged. Thanks.

I've been doing this already in the PR body so that things are cleanly linked back rather than from some commit that might never actually make it into a deploy branch. "Resolves" is in the word list of keywords that can close Issues (c.f. https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) so in the PR body when I start it with

Resolves #1474

it sets up the close on merge just as "fixes" would do:

Screenshot from 2023-02-15 03-02-57

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1906/c1430978204@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1906#issuecomment-1430978204", "url": "https://github.com/xrootd/xrootd/pull/1906#issuecomment-1430978204", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1