Print

Print

@amadio commented on this pull request.

In .github/workflows/build.yml:

> @@ -76,7 +76,7 @@ jobs:
             -DCMAKE_CXX_STANDARD=17 \
             -DCMAKE_BUILD_TYPE=RelWithDebInfo \
             -DCMAKE_INSTALL_PREFIX=/usr \
-            -DPYTHON_EXECUTABLE=$(command -v python3) \
+            -DPython_EXECUTABLE=$(command -v python3) \

I think these could actually be removed, as CMake will find /usr/bin/python3 just fine, but I can do this later.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <xrootd/xrootd/pull/1906/review/1299084722@github.com>

[ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/xrootd/xrootd/pull/1906#pullrequestreview-1299084722", "url": "https://github.com/xrootd/xrootd/pull/1906#pullrequestreview-1299084722", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1