@amadio commented on this pull request.
> @@ -50,13 +50,6 @@ if( CMAKE_COMPILER_IS_GNUCXX )
set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Werror" )
endif()
set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unused-parameter" )
- # gcc 4.1 is retarded
- execute_process( COMMAND ${CMAKE_C_COMPILER} -dumpversion
- OUTPUT_VARIABLE GCC_VERSION )
- if( (GCC_VERSION VERSION_GREATER 4.1 OR GCC_VERSION VERSION_EQUAL 4.1)
- AND GCC_VERSION VERSION_LESS 4.2 )
- set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-strict-aliasing" )
- endif()
if( GCC_VERSION VERSION_GREATER 4.8.0 )
This depends on the `execute_process` being removed, that's why all builds broke.
--
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1911#pullrequestreview-1303079459
You are receiving this because you are subscribed to this thread.
Message ID: <[log in to unmask]>
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
