Print

Print


@amadio commented on this pull request.



> +//! Return advanced error information about the last error encountered by
+//! this object.  Only invoked if the XrdOSS indicates it has feature XRDOSS_AERR
+//! The advanced error feature provides the ability for more error information
+//! than is possible from the typical error code (e.g., unstructured error
+//! messages).
+//!
+//! @return Error object associated with the last error.  Caller does not own
+//! the returned memory.  Lifetime of the returned object is only guaranteed
+//! until the next method call.  May return nullptr even if an error occurred.
+//-----------------------------------------------------------------------------
+
+#if XRDOSS_ERR
+virtual const XrdOucErrInfo *getError() const;
+#else
+const XrdOucErrInfo *getError() const;
+#endif

I am not a fan of changing interface in this manner. I think it's better to have a clean patch and add it only in the next major version.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1913#pullrequestreview-1307090779
You are receiving this because you are subscribed to this thread.

Message ID: <[log in to unmask]>

########################################################################
Use REPLY-ALL to reply to list

To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1