@amadio commented on this pull request.
> @@ -63,6 +63,12 @@ int initErrTable()
lastGood = i;
}
}
+ // NOTE: On systems without EAUTH (authentication error; currently all Glibc systems but GNU Hurd),
+ // EAUTH is remapped to EBADE ('invalid exchange'). Given there's no current XRootD use of a
+ // syscall that can return EBADE, we assume EBADE really means authentication denied.
+#if defined(EBADE)
+ Errno2String[EBADE] = "authentication failed";
+#endif
Another minor note. Is the assumption that `EBADE` == authentication failed reasonable? Can something else be mistaken for authentication failure because of this?
Checking a bit, I also figured out that macOS has `EAUTH` but not `EBADE`, and on Linux musl doesn't seem to have either. I wonder what happens in that case.
--
Reply to this email directly or view it on GitHub:
https://github.com/xrootd/xrootd/pull/1916#pullrequestreview-1307519661
You are receiving this because you are subscribed to this thread.
Message ID: <[log in to unmask]>
########################################################################
Use REPLY-ALL to reply to list
To unsubscribe from the XROOTD-DEV list, click the following link:
https://listserv.slac.stanford.edu/cgi-bin/wa?SUBED1=XROOTD-DEV&A=1
